Skip to content

fix: streaming rpc #60

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

fix: streaming rpc #60

merged 1 commit into from
Mar 19, 2025

Conversation

GabrielePicco
Copy link
Contributor

Description

Status Type ⚠️ Core Change Issue
Ready Bug No -

Problem

  • Under caertain circumstances, the main thread was locked on connect_async and disconnect_async
  • Unable to use a custom IWebsocket implementation

Solution

  • Fixed awaiter and async
  • Added an overload method on ClientFactory.GetStreamingClient that allow to pass an IWebsocket instance

@GabrielePicco GabrielePicco mentioned this pull request Mar 19, 2025
Merged
@GabrielePicco GabrielePicco merged commit aadb40d into master Mar 19, 2025
1 check failed
@GabrielePicco GabrielePicco deleted the fix/streaming-rpc-v2 branch March 19, 2025 13:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GabrielePicco