Avoid -Wincomplete-uni-patterns in generated splices
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorki
commented
Dec 15, 2023
Merged
sorki
force-pushed
the
srk/incomplete-uni-patterns
branch
from
f6a405c to
4a74cc6
Compare
|
You'll need to change those |
Resolves warnings coming from TH splices, like
```haskell
src/Ivory/Compile/C/Gen.hs:314:25: warning: [GHC-62161] [-Wincomplete-uni-patterns]
Pattern match(es) are non-exhaustive
In a pattern binding:
Patterns of type ‘C.Type’ not matched:
C.AntiType _ _
C.Type (C.AntiDeclSpec _ _) _ _
C.Type (C.AntiTypeDeclSpec _ _ _ _) _ _
|
314 | [C.BlockStm [cstm| for( $ty:(toType ty) $id:(toVar var)
```
sorki
force-pushed
the
srk/incomplete-uni-patterns
branch
from
4a74cc6 to
2eb249d
Compare
Ah, of course, that's why CI fails. Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves warnings coming from TH splices, like