Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(Update): implement python package entries #2092

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

Jomik
Copy link
Contributor

@Jomik Jomik commented Dec 22, 2024

Description

This PR adds support for python applications, see Moonraker Python Application

Related Tickets & Documents

Discord Thread

Testing:

[update_manager python_test]
type: python
channel: dev
virtualenv: ~/klippy-env
project_name: cartographer
is_system_service: False
managed_services: klipper
info_tags: desc=Python Test

You will have to do the initial install with ~/klippy-env/bin/pip install git+https://github.com/Jomik/cartographer-scanner-klippy.git
To uninstall ~/klippy-env/bin/pip uninstall cartographer

Mobile & Desktop Screenshots/Recordings

image
image
image
image

[optional] Are there any post-deployment tasks we need to perform?

No

Signed-off-by: Jonas Damtoft <jonasdamtoft@gmail.com>
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 22, 2024
@meteyou meteyou self-requested a review December 31, 2024 15:58
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
Copy link
Member

meteyou commented Dec 31, 2024

@Jomik can you pls post a working moonraker config for this feature?

@Jomik
Copy link
Contributor Author

Jomik commented Jan 1, 2025

@meteyou I have updated the description with a configuration section and the commands needed.
Do note mainsail-crew/virtual-klipper-printer#41 if you try to test it in the virtual printer.

But you can probably also just adjust the configuration to create its own venv and install into that.

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 30, 2025
@meteyou meteyou merged commit 60f7f37 into mainsail-crew:develop Jan 30, 2025
11 checks passed
@meteyou
Copy link
Member

meteyou commented Jan 30, 2025

@Jomik sry for the delay. I double checked the PR and merged it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants