feat(Temperatures): add menu to open Settings & turn off heaters #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… heaters Signed-off-by: Stefan Dej <meteyou@gmail.com>
dosubot
bot
added
the
size:M
|
Language file analysis report:
|
dw-0
requested changes
Dec 29, 2024
contentMenu to contextMenu Signed-off-by: Stefan Dej <meteyou@gmail.com>
|
Language file analysis report:
|
… eventBus.ts Signed-off-by: Stefan Dej <meteyou@gmail.com>
|
Language file analysis report:
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a ContextMenu to each entry in the Temperature Panel to open the Settings dialog and for heaters add an option to turn of this specific heater.
Related Tickets & Documents
none
Mobile & Desktop Screenshots/Recordings
If heater has a target temp:
If heater has 0 as target temp:
If the line is no heater:
[optional] Are there any post-deployment tasks we need to perform?
none