Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Align assemblies autothreading #72

Merged
merged 20 commits into from
Dec 15, 2023
Merged

Align assemblies autothreading #72

merged 20 commits into from
Dec 15, 2023

Conversation

lynnjo
Copy link
Collaborator

@lynnjo lynnjo commented Dec 14, 2023

Description

Provide a summary of your changes including motivation and context.
If these changes fix a bug or resolves a feature request, be sure to link to that issue.

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated relevant documentation

Changelog entry

Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.
made total-threads and in-parallel optional parameters for align-assemblies

made total-threads and in-parallel optional parameters for align-assemblies

@lynnjo lynnjo self-assigned this Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (4fdf8b1) 87.19% compared to head (8292319) 86.52%.
Report is 2 commits behind head on main.

❗ Current head 8292319 differs from pull request most recent head c4d1e26. Consider uploading reports for the commit c4d1e26 to get more accurate results

Files Patch % Lines
...lin/net/maizegenetics/phgv2/cli/AlignAssemblies.kt 71.60% 18 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   87.19%   86.52%   -0.67%     
==========================================
  Files          22       22              
  Lines        2077     2145      +68     
  Branches      285      300      +15     
==========================================
+ Hits         1811     1856      +45     
- Misses        152      170      +18     
- Partials      114      119       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@btmonier btmonier self-requested a review December 15, 2023 13:12
@lynnjo lynnjo merged commit 903568f into main Dec 15, 2023
1 check passed
@lynnjo lynnjo deleted the align_assemblies_autothreading branch December 15, 2023 13:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants