Add getMultiWithErrors

makenotion · Sep 27, 2023 · 9d21572 · 9d21572
1 parent 2ede258
commit 9d21572
Show file tree

Hide file tree

Showing 4 changed files with 103 additions and 2 deletions.
diff --git a/lib/memjs/memjs.d.ts b/lib/memjs/memjs.d.ts
@@ -36,6 +36,15 @@ export interface GetResult<Value = MaybeBuffer, Extras = MaybeBuffer> {
 export declare type GetMultiResult<Keys extends string = string, Value = MaybeBuffer, Extras = MaybeBuffer> = {
     [K in Keys]?: GetResult<Value, Extras>;
 };
+export interface GetMultiError<Keys extends string = string> {
+    error: Error;
+    serverKey: string;
+    keys: Keys[];
+}
+export interface GetMultiWithErrorsResult<Keys extends string = string, Value = MaybeBuffer, Extras = MaybeBuffer> {
+    result: GetMultiResult<Keys, Value, Extras>;
+    errors: GetMultiError<Keys>[];
+}
 declare class Client<Value = MaybeBuffer, Extras = MaybeBuffer> {
     servers: Server[];
     seq: number;
@@ -126,6 +135,7 @@ declare class Client<Value = MaybeBuffer, Extras = MaybeBuffer> {
      * requested keys to results, or null if the key was not found.
      */
     getMulti<Keys extends string>(keys: Keys[]): Promise<GetMultiResult<Keys, Value, Extras>>;
+    getMultiWithErrors<Keys extends string>(keys: Keys[]): Promise<GetMultiWithErrorsResult<Keys, Value, Extras>>;
     /**
      * Sets `key` to `value`.
      */

diff --git a/lib/memjs/memjs.d.ts.map b/lib/memjs/memjs.d.ts.map
diff --git a/lib/memjs/memjs.js b/lib/memjs/memjs.js
diff --git a/src/memjs/memjs.ts b/src/memjs/memjs.ts
@@ -97,6 +97,21 @@ export type GetMultiResult<
   [K in Keys]?: GetResult<Value, Extras>;
 };
 
+export interface GetMultiError<Keys extends string = string> {
+  error: Error;
+  serverKey: string;
+  keys: Keys[];
+}
+
+export interface GetMultiWithErrorsResult<
+Keys extends string = string,
+Value = MaybeBuffer,
+Extras = MaybeBuffer
+> {
+  result: GetMultiResult<Keys, Value, Extras>;
+  errors: GetMultiError<Keys>[];
+}
+
 class Client<Value = MaybeBuffer, Extras = MaybeBuffer> {
   servers: Server[];
   seq: number;
@@ -384,6 +399,48 @@ class Client<Value = MaybeBuffer, Extras = MaybeBuffer> {
     return Object.assign({}, ...results);
   }
 
+  async getMultiWithErrors<Keys extends string>(
+    keys: Keys[]
+  ): Promise<GetMultiWithErrorsResult<Keys, Value, Extras>> {
+    const serverKeytoLookupKeys: {
+      [serverKey: string]: Keys[];
+    } = {};
+    keys.forEach((lookupKey) => {
+      const serverKey = this.lookupKeyToServerKey(lookupKey);
+      if (!serverKeytoLookupKeys[serverKey]) {
+        serverKeytoLookupKeys[serverKey] = [];
+      }
+      serverKeytoLookupKeys[serverKey].push(lookupKey);
+    });
+
+    const usedServerKeys = Object.keys(serverKeytoLookupKeys);
+    const errors: GetMultiError<Keys>[] = [];
+    const results = await Promise.all(
+      usedServerKeys.map(async (serverKey) => {
+        const server = this.serverKeyToServer(serverKey);
+        try {
+          return await this._getMultiToServer(server, serverKeytoLookupKeys[serverKey]);
+        } catch (err) {
+          let error: Error;
+          if (err instanceof Error) {
+            error = err;
+          } else {
+            error = new Error("Unknown Error");
+            (error as any).thrown = err;
+          }
+
+          errors.push({
+            error,
+            serverKey,
+            keys: serverKeytoLookupKeys[serverKey]
+          });
+        }
+      })
+    );
+
+    return { result: Object.assign({}, ...results), errors };
+  }
+
   /**
    * Sets `key` to `value`.
    */