Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add key generation margin when comparing against detected device #91

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

malmeloo
Copy link
Owner

@malmeloo malmeloo commented Dec 5, 2024

Accessories may experience time drift of their internal clock after being separated from their owner device(s) for too long - up to ~17 seconds per day. This may cause issues when verifying whether a tag belongs to a certain device that we found in the wild. To fix this, a time margin of 12 hours was added in both directions, which should account for this potential time drift.

@malmeloo malmeloo merged commit b171755 into main Dec 23, 2024
7 checks passed
@malmeloo malmeloo deleted the fix/nearby-device-discovery branch December 23, 2024 15:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant