Fix unit tests

mamba-org · May 20, 2020 · 7a09cb9 · 7a09cb9
1 parent 035f6f4
commit 7a09cb9
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 8 deletions.
diff --git a/jupyter_conda/envmanager.py b/jupyter_conda/envmanager.py
@@ -256,7 +256,6 @@ async def export_env(
                 )
             else:
                 command.append("--from-history")
-
         ans = await self._execute(*command)
         rcode, output = ans
         if rcode > 0:

diff --git a/jupyter_conda/tests/test_api.py b/jupyter_conda/tests/test_api.py
@@ -579,12 +579,10 @@ def test_env_export_history(self):
         )
 
     def test_env_export_not_supporting_history(self):
-        manager = TestEnvironmentHandler.notebook.web_app.settings["env_manager"]
-        manager._conda_version = (4, 6, 0)
-
         try:
             n = generate_name()
             self.wait_for_task(self.mk_env, n)
+            EnvManager._conda_version = (4, 6, 0)
             r = self.conda_api.get(
                 ["environments", n], params={"download": 1, "history": 1}
             )
@@ -597,7 +595,7 @@ def test_env_export_not_supporting_history(self):
             self.assertRegex(content, r"- python=\d\.\d+\.\d+=\w+")
             self.assertRegex(content, r"prefix:")
         finally:
-            manager._conda_version = None
+            EnvManager._conda_version = None
 
 
 class TestCondaVersion(JupyterCondaAPITest):

diff --git a/labextension/src/__tests__/services.spec.ts b/labextension/src/__tests__/services.spec.ts
@@ -249,7 +249,7 @@ describe("jupyterlab_conda/services", () => {
     // TODO describe("dispose()", () => {});
 
     describe("export()", () => {
-      it("should request to export", async () => {
+      it("should request to export in full format", async () => {
         const name = "dummy";
         (ServerConnection.makeRequest as jest.Mock).mockResolvedValue(
           new Response("", { status: 200 })
@@ -258,7 +258,33 @@ describe("jupyterlab_conda/services", () => {
         const envManager = new CondaEnvironments();
         await envManager.export(name);
 
-        const queryArgs = URLExt.objectToQueryString({ download: 1 });
+        const queryArgs = URLExt.objectToQueryString({
+          download: 1,
+          history: 0
+        });
+        expect(ServerConnection.makeRequest).toBeCalledWith(
+          URLExt.join(settings.baseUrl, "conda", "environments", name) +
+            queryArgs,
+          {
+            method: "GET"
+          },
+          settings
+        );
+      });
+
+      it("should request to export in history format", async () => {
+        const name = "dummy";
+        (ServerConnection.makeRequest as jest.Mock).mockResolvedValue(
+          new Response("", { status: 200 })
+        );
+
+        const envManager = new CondaEnvironments();
+        await envManager.export(name, true);
+
+        const queryArgs = URLExt.objectToQueryString({
+          download: 1,
+          history: 1
+        });
         expect(ServerConnection.makeRequest).toBeCalledWith(
           URLExt.join(settings.baseUrl, "conda", "environments", name) +
             queryArgs,
@@ -364,6 +390,7 @@ describe("jupyterlab_conda/services", () => {
             get: jest.fn().mockImplementation((key: string) => {
               // @ts-ignore
               return {
+                fromHistory: { composite: false },
                 types: { composite: {} },
                 whitelist: { composite: true }
               }[key];

diff --git a/labextension/src/tokens.ts b/labextension/src/tokens.ts
@@ -54,7 +54,7 @@ export interface IEnvironmentManager extends IDisposable {
    * @param name Name of the environment to be exported
    * @param fromHistory Whether to export only from the history
    */
-  export(name: string, fromHistory: boolean): Promise<Response>;
+  export(name: string, fromHistory?: boolean): Promise<Response>;
   /**
    * Create an environment from a packages list file
    *