Layout for tek4404 #13534
Open
Layout for tek4404 #13534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Apr 25, 2025
Comment on lines
+32
to
+34
| <element name="spacer" ref="static_black"> | ||
| <bounds x="0" y="480" width="640" height="16" /> | ||
| </element> |
There was a problem hiding this comment.
You don’t really need this thing as you’ve got explicit bounds for the view, and the LEDs will draw on top of the black background anyway. But if you insist on using it, you’re better off putting it behind the screen rather than on top to ensure it doesn’t slightly crop the bottom of the screen when the floating point view coordinates are quantised to whole pixel values.
Comment on lines
+36
to
+50
| <element name="led_1" ref="led_round"> | ||
| <bounds x="46" y="484" width="8" height="8" /> | ||
| </element> | ||
| <element name="led_2" ref="led_round"> | ||
| <bounds x="34" y="484" width="8" height="8" /> | ||
| </element> | ||
| <element name="led_4" ref="led_round"> | ||
| <bounds x="22" y="484" width="8" height="8" /> | ||
| </element> | ||
| <element name="led_8" ref="led_round"> | ||
| <bounds x="10" y="484" width="8" height="8" /> | ||
| </element> | ||
| <element name="led_disk" ref="led_rect"> | ||
| <bounds x="614" y="485" width="16" height="6" /> | ||
| </element> |
There was a problem hiding this comment.
Would it be a good idea to add text labels for the LEDs? As it is, there are three identical-looking round LEDs, the function of which won’t be clear without examining the source. Also, the outputs corresponding to these don’t appear to actually be hooked up?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has 4 status LEDs (inside display on 4404) as well as HD activity LED