Skip to content

Commit

Permalink
Fix obsolete fixture name
Browse files Browse the repository at this point in the history
  • Loading branch information
phoebusm committed Nov 14, 2024
1 parent 1659be2 commit 93c4cfa
Showing 1 changed file with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,11 @@ def test_symbol_list_regex(basic_store):
@pytest.mark.parametrize("compact_first", [True, False])
# Using S3 because LMDB does not allow OpenMode to be changed
def test_symbol_list_read_only_compaction_needed(
small_max_delta, object_version_store, compact_first, native_variant_storage_map
small_max_delta, object_version_store, compact_first, s3_native_config
):
lib_write = object_version_store

lib_read = make_read_only(lib_write, native_variant_storage_map)
lib_read = make_read_only(lib_write, s3_native_config)

lt = lib_write.library_tool()
old_compaction = []
Expand Down Expand Up @@ -222,7 +222,7 @@ def test_only_latest_compaction_key_is_used(basic_store):

@pytest.mark.parametrize("write_another", [False, True])
def test_turning_on_symbol_list_after_a_symbol_written(
object_store_factory, write_another, native_variant_storage_map
object_store_factory, write_another, s3_native_config
):
# The if(!maybe_last_compaction) case
lib: NativeVersionStore = object_store_factory(symbol_list=False)
Expand All @@ -241,7 +241,7 @@ def test_turning_on_symbol_list_after_a_symbol_written(
k.id == CompactionId for k in sl_keys
), "Should not have any compaction yet"

ro = make_read_only(lib, native_variant_storage_map)
ro = make_read_only(lib, s3_native_config)
# For some reason, symbol_list=True is not always picked up on the first call, so forcing it:
symbols = ro.list_symbols(use_symbol_list=True)
assert set(symbols) == ({"a", "b"} if write_another else {"a"})
Expand Down Expand Up @@ -420,9 +420,9 @@ def test_force_compact_symbol_list(lmdb_version_store_v1):


# Using S3 because LMDB does not allow OpenMode to be changed
def test_force_compact_symbol_list_read_only(s3_version_store_v1, native_variant_storage_map):
def test_force_compact_symbol_list_read_only(s3_version_store_v1, s3_native_config):
lib_write = s3_version_store_v1
lib_read_only = make_read_only(lib_write, native_variant_storage_map)
lib_read_only = make_read_only(lib_write, s3_native_config)
# No symbol list keys
with pytest.raises(PermissionException):
lib_read_only.compact_symbol_list()
Expand Down

0 comments on commit 93c4cfa

Please # to comment.