Fix resource decompression when resource has multi-byte characters #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decompression code has bugs that will be difficult to fix with the version of JS supported by wkhtmltox. This prevents us from compressing the resources when saving the html to convert.
The standard `fromCharCode` we were using to decode character-by-character was using UTF-16 by default. This was a problem when we had utf-8 encoded resources and so we use TextDecoder to decode these. However, the TextDecoder API is not available in wkhtmltox, which is the reason for disabling the compression entirely when using wkhtmltox.
rspencer01
changed the title
mrjackbarker
approved these changes
Jan 8, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decompression code has bugs that will be difficult to fix with the version of JS supported by wkhtmltox. This prevents us from compressing the resources when saving the html to convert.
Once this is done we can then use
TextDecoderto decode resources as utf-8 instead of utf-16 (the default for JavaScript) which fixes #136 . There is still a small bug that if a character lies on a 1024 byte boundary we truncate it, but this should be addressed by #137