Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bugfix] Render resources in iPython cells #146

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

rspencer01
Copy link
Collaborator

We were not rendering resources (CSS and JS) for blocks in iPython or Jupyter cells. This renders them as part of the block.

We were not rendering resources (CSS and JS) for blocks in iPython or
Jupyter cells. This renders them as part of the block.
@rspencer01 rspencer01 added the bug label Jan 17, 2025
@coveralls
Copy link

coveralls commented Jan 17, 2025

Coverage Status

coverage: 87.626% (+0.3%) from 87.329%
when pulling df816a9 on rspencer01:render_resources
into a5dc5cb on man-group:master.

Copy link

@jonbannister jonbannister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any test that could be added that asserts we're now rendering the resources?

@rspencer01 rspencer01 requested a review from morotti January 20, 2025 13:12
@rspencer01
Copy link
Collaborator Author

Good shout - I'll add one

@rspencer01 rspencer01 merged commit 31abe72 into man-group:master Jan 22, 2025
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants