Set the Windows Terminal as the default terminal

[d35ha]

Closes #971.
Closes #973.

[Ana06]

I am not sure this works as proposed in #971. @d35ha can you provide more details on how this works and how it looks like (maybe adding a screenshot)?

[d35ha]

@Ana06
I've created a console app, here is how its execution looks before and after setting these registry values:

Also, running cmd or powershell (from start menu or by double-clicking) opens it in Windows Terminal.

[d35ha]

@Ana06
#973 is also addressed in this PR.

[Ana06]

@d35ha is proposing using the windows terminal to open the shortcuts in the Tools directory, is this PR achieving this?

[d35ha]

@Ana06
Any application that requires a console would be assigned the Windows terminal console instead of the the old conhost.exe (that is including the shortcuts under the Tools directory).

[Ana06]

I am using 10.0.19045.0 (downloaded from the recommended link in FLARE-VM), so this approach does not work

[emtuls]

I looked into this a little bit more.

I wanted to try and find a way to have any "console app" shortcut open with Windows Terminal (if it exists) or cmd.exe if not, but the way to make that happen would likely require an external script to launch the correct one. I tried creating a singular command that can be done within a shortcut target cmd, but it ended up being too long.

An alternative would be that we force Windows Terminal to be installed, but I believe this would require modification of our install script so that it is always installed if I'm not mistaken?

Let me know if that's the preferred route and I can work on that.

[emtuls]

Assuming we go the route of a forced Windows Terminal install...I got something mostly working for Command Prompt, but it seems like Powershell is going to be a lot more of an issue due to a long standing bug with Windows Terminal and how it interprets semicolons: microsoft/terminal#13264

This makes it very difficult, if not impossible to do our powershell shortcuts. I was able to make one work, but it would require removing the Write-Host portion (echoing the command we write into the console).

For reference for powershell, I modified powersploit to use this as arguments for VM-Install-Shortcut:
$powershellCommand = 'Get-Command -Module (Import-Module .\Recon\Recon.psd1)'

This still seems to work as expected, just a re-write of the original command we used so it doesn't use a semicolon:
Import-Module .\Recon\Recon.psd1 ; Get-Command -Module Recon

And I modified VM-Install-Shortcut to use the following for the else statement (for when it is powershell):

$executableCmd = Get-ChildItem "C:\Tools\Windows Terminal\terminal-*" -Filter wt.exe -Recurse | Select-Object -ExpandProperty FullName -First 1
VM-Assert-Path $executableCmd
$executableArgs = "-p `"Powershell`" -d `"$executableDir`" `"powershell.exe -ExecutionPolicy Bypass -NoExit -Command ""$arguments""`""

This generated the following shortcut target:
"C:\Tools\Windows Terminal\terminal-1.19.10573.0\wt.exe" -p "PowerShell" "powershell.exe -NoExit -Command ""Get-Command -Module (Import-Module .\Recon\Recon.psd1)""

For reference for Command Prompt (console apps) that seems to just 'work', I tested with exiftool and only had to modify VM-Install-Shortcut:

if ($consoleApp) {
    $executableCmd = Get-ChildItem "C:\Tools\Windows Terminal\terminal-*" -Filter wt.exe -Recurse | Select-Object -ExpandProperty FullName -First 1
    VM-Assert-Path $executableCmd
    # Set the starting directory, print the command, and execute it within wt.exe
    $executableArgs = "-p `"Command Prompt`" -d `"$executableDir`" `"cmd.exe /k echo $executablePath $arguments && $executablePath $arguments`""

[Ana06]

Thanks for the research @emtuls! I suggest we merge this PR as it is, as it seems it is not easy to support it in our Windows version.

[Ana06]

I think it is nice that previous versions benefit from the improvement even if it does not work in older version. I have tested it in 10.0.19045.0 and it does not seem to introduce any issues (it also does modify the behavior).