Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Yanmaga: Fix error handling and restore _getMangaFromURI #7802

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

clfws9
Copy link

@clfws9 clfws9 commented Mar 6, 2025

If a user tries to download a chapter that requires rental or login, an exception is thrown in the _getPageList function.
However, because the exception is not handled, there is no indication in the UI that the download has failed.
I have fixed this by handling the exception.

Also, since switching from ComiciViewer to SpeedBinb (e93e7c1), copy and paste support seems to be broken.
I have restored the _getMangaFromURI function from the following part.

async _getMangaFromURI(uri) {
const request = new Request(uri);
const [data] = await this.fetchDOM(request, '.detailv2-outline-title');
const id = uri.pathname;
const title = data.textContent.trim();
return new Manga(this, id, title);
}

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant