Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mangago : fix randomly getting only 5 pages #1038

Merged
merged 2 commits into from
Mar 1, 2025
Merged

Mangago : fix randomly getting only 5 pages #1038

merged 2 commits into from
Mar 1, 2025

Conversation

MikeZeDev
Copy link
Contributor

@MikeZeDev MikeZeDev commented Feb 24, 2025

@MikeZeDev MikeZeDev requested a review from ronny1982 February 24, 2025 19:40
@ronny1982
Copy link
Contributor

Since there was no test case added, I assume the current test case would be affected by the change.
However, the current implementation of MangaGo works just fine with the current test case (chapter 10 shows 66 images)

@MikeZeDev
Copy link
Contributor Author

MikeZeDev commented Feb 26, 2025

Of course the tests are "working", as they doesn't even cover gathering chapters.

Chapter id (host + pathname) is random and can change between two fetches of the same manga page.

If chapter id match a certain pattern old code still works. Otherwise new code is mandatory.

Its pointless try to add "test for new changes" as we wont necessarily encounter it twice in a row for the same manga/chapter.

@MikeZeDev
Copy link
Contributor Author

MikeZeDev commented Feb 26, 2025

this is what i got on chapter 10 with old code

https://www.youhim.me/chapter/72005/1708354/ or https://www.mangago.zone/chapter/72005/1708354/

image

66 "images" yeah... we got only first five.

Old code only work with "chapter 10" https://www.mangago.me/read-manga/the_dame_in_shining_armor/uu/to_chapter-10/pg-1/
image

@MikeZeDev MikeZeDev changed the title Mangago : handle multipaged chapters Mangago : fix randomly getting only 5 pages Feb 26, 2025
@ronny1982
Copy link
Contributor

ronny1982 commented Feb 26, 2025

Of course i didn't run the test automatically since it is commented out.
I was referring to the test case which I performed manually and all 66 images showed up.

So the essential information which was not clear to me is the origin. Chapters on mangago.me contain all images, while fake domains do not.

I will check this when i got some spare time.

@MikeZeDev
Copy link
Contributor Author

I see what you want to do. Not sure its 100% reliable but its worth a try :)

@MikeZeDev
Copy link
Contributor Author

@ronny1982 your solution seems to works well.

@MikeZeDev MikeZeDev merged commit 778e1a6 into master Mar 1, 2025
6 checks passed
@MikeZeDev MikeZeDev deleted the mangago branch March 1, 2025 16:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants