Improve TelUri parsing performance #38

blendmaster · 2015-12-04T18:03:49Z

More upstream parity from fullcontact/ez-vcard.

That regex is sloow.

instead return null, for less expense when parsing lots of vcards.

codecov-io · 2015-12-04T18:05:42Z

Current coverage is `76.10%`

Merging #38 into master will decrease coverage by -0.03% as of a802efc

@@            master    #38   diff @@
=====================================
  Files          203    203       
  Stmts         7374   7374       
  Branches      1141   1144     +3
  Methods                         
=====================================
- Hit           5614   5612     -2
- Partial        237    239     +2
  Missed        1523   1523

Review entire Coverage Diff as of a802efc

Powered by Codecov. Updated on successful CI builds.

mangstadt · 2015-12-05T17:28:03Z

Thanks for the idea, @blendmaster. I went a step further and removed calls to String.split(), since this method uses a regular expression as well. See commits 0e232d5 and 389ef2b.

blendmaster added 2 commits December 4, 2015 11:00

TelUri: replace terrible regex with manual parse

10b7a59

That regex is sloow.

TelUri: don't throw IAE for bad parses

a4bd5da

instead return null, for less expense when parsing lots of vcards.

mangstadt added the enhancement label Dec 5, 2015

mangstadt closed this Dec 5, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve TelUri parsing performance #38

Improve TelUri parsing performance #38

blendmaster commented Dec 4, 2015

codecov-io commented Dec 4, 2015

mangstadt commented Dec 5, 2015

Improve TelUri parsing performance #38

Improve TelUri parsing performance #38

Conversation

blendmaster commented Dec 4, 2015

codecov-io commented Dec 4, 2015

Current coverage is 76.10%

mangstadt commented Dec 5, 2015

Current coverage is `76.10%`