Log parser time mean #35093
Merged
Log parser time mean #35093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmborr
requested changes
Jan 26, 2023
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
peterfpeterson
force-pushed
the
log_parser_time_mean
branch
2 times, most recently
from
74ce848 to
605f6e5
Compare
github-actions
bot
removed
the
Has Conflicts
peterfpeterson
force-pushed
the
log_parser_time_mean
branch
2 times, most recently
from
cc72ee9 to
82d38f5
Compare
jmborr
requested changes
Feb 2, 2023
Framework/PythonInterface/test/python/plugins/algorithms/ExportSampleLogsToHDF5Test.py
Show resolved
Hide resolved
jmborr
previously approved these changes
Feb 2, 2023
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
peterfpeterson
force-pushed
the
log_parser_time_mean
branch
from
e723501 to
19ba43f
Compare
github-actions
bot
added
Has Conflicts
|
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
peterfpeterson
force-pushed
the
log_parser_time_mean
branch
from
19ba43f to
2b84f94
Compare
github-actions
bot
removed
the
Has Conflicts
Some of the test had their values of correct changed to reflect new contribution of final time interval based on bugfix.
peterfpeterson
force-pushed
the
log_parser_time_mean
branch
from
2b84f94 to
6e76873
Compare
jmborr
approved these changes
Feb 7, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While walking through code I discovered that LogParser had a parallel implementation of calculating time average mean values. This merges it with the central version in TimeSeriesProperty.
To test:
The existing tests should all still pass.
Refs #34794.
This does not require release notes because it is a refactor to remove duplicate implementations.
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.