Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add information on how time average mean works #35175

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

peterfpeterson
Copy link
Member

As part of the event filtering work, this improvement to the event filtering concept page is meant to help the user better understand how mantid calculates time average values.

To test:

Refs #34794

This does not require release notes because it is adding documentation on how time-average values work.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@peterfpeterson peterfpeterson added the Documentation Issues and pull requests related to documentation label Feb 6, 2023
@peterfpeterson peterfpeterson added this to the Release 6.7 milestone Feb 6, 2023
@jhaigh0 jhaigh0 self-assigned this Feb 7, 2023
AndreiSavici
AndreiSavici previously approved these changes Feb 7, 2023
@jhaigh0 jhaigh0 removed their assignment Feb 7, 2023
@jmborr jmborr enabled auto-merge February 7, 2023 21:06
@jmborr jmborr merged commit 44d2687 into mantidproject:main Feb 7, 2023
@peterfpeterson peterfpeterson deleted the filtering_concept branch February 8, 2023 13:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Documentation Issues and pull requests related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants