Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add TimeSplitter object #35191

Merged
merged 7 commits into from
Feb 13, 2023

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Feb 8, 2023

The initial object for a time splitter which is meant to unify all the other ways of specifying splitting. This is not connected to anything yet.

To test:

Code review is the best way.

Refs #34794

This does not require release notes because it is a class that is not currently used anywhere.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@peterfpeterson peterfpeterson added this to the Release 6.7 milestone Feb 8, 2023
@peterfpeterson peterfpeterson marked this pull request as ready for review February 8, 2023 21:10
jmborr
jmborr previously approved these changes Feb 13, 2023
@rosswhitfield rosswhitfield merged commit 3fe792e into mantidproject:main Feb 13, 2023
@peterfpeterson peterfpeterson deleted the time_splitter_obj branch February 13, 2023 18:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants