Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove splitByTime #35451

Merged
merged 1 commit into from
Apr 13, 2023
Merged

remove splitByTime #35451

merged 1 commit into from
Apr 13, 2023

Conversation

searscr
Copy link
Contributor

@searscr searscr commented Apr 12, 2023

Description of work.
This removes old functions that are no longer used. These functions have been replaced with new and improved functionality.

To test:
All Existing Tests should pass.

Refs #34794


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@searscr searscr marked this pull request as draft April 12, 2023 19:59
@searscr searscr force-pushed the ewm742_removeSplitByTime branch from 8be9e15 to 3cdda2c Compare April 12, 2023 20:09
@searscr searscr marked this pull request as ready for review April 13, 2023 12:55
@searscr searscr force-pushed the ewm742_removeSplitByTime branch from 3cdda2c to 23a4276 Compare April 13, 2023 13:04
@peterfpeterson peterfpeterson added this to the Release 6.7 milestone Apr 13, 2023
@jmborr jmborr enabled auto-merge April 13, 2023 14:25
@jmborr jmborr merged commit 28b2a6a into main Apr 13, 2023
@jmborr jmborr deleted the ewm742_removeSplitByTime branch April 13, 2023 16:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants