Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add method numberOfRegions to TimeROI #35457

Merged

Conversation

peterfpeterson
Copy link
Member

Convenience function for getting the number of intervals.

To test:

Check out the new tests.

Refs #34794.

This does not require release notes because it is already encompassed in the larger event filtering release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@peterfpeterson peterfpeterson added this to the Release 6.7 milestone Apr 13, 2023
Copy link
Contributor

@searscr searscr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward and adequately tested.

@rosswhitfield rosswhitfield merged commit 12f437c into mantidproject:main Apr 14, 2023
@peterfpeterson peterfpeterson deleted the timeroi_num_splitters branch April 14, 2023 12:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants