-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Include shaded regions for log values outside TimeROI #35492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running (data is in the system tests area
Load(Filename="HYS_13656-13658", OutputWorkspace="sum")
then bringing up the log viewer does not disable the "Time ROI" button when sum.run().getTimeROI().useAll()
is True
Running
Load(Filename="HYS_13656-13658", OutputWorkspace="sum")
FilterByLogValue(
InputWorkspace="sum", OutputWorkspace="sum", LogName="s1", MinimumValue="0", MaximumValue="24.5", LogBoundary="Left"
)
works exactly as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
Description of work
Add a shaded region to sample logs plots that show regions of the logs being excluded by the TimeROI. The option is enabled by default in the Sample Log view and can be enabled in python scripts by including
ShowTimeROI=True
in the argument list.To test:
Running this script will display a plot with shaded regions where TimeROI is excluding values.

Viewing the logs before filtering will have the extra control disabled.
This PR is part of #34794.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.