Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move from poco::file to std::filesystem - Kernel #37870

Merged

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Aug 23, 2024

This is the first of probably many PRs to move from Poco::File and Poco::Path to std::filesystem. This does not remove all use of Poco::File from Kernel.

Refs #37868

To test:

This is a refactor for modernization. If the existing tests pass, it works.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@peterfpeterson peterfpeterson added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Aug 23, 2024
@peterfpeterson peterfpeterson added this to the Release 6.11 milestone Aug 23, 2024
@peterfpeterson peterfpeterson force-pushed the 37868_kernel_filesystem branch 2 times, most recently from 26cda98 to 181925f Compare August 23, 2024 15:12
@peterfpeterson peterfpeterson changed the title Move from poco::file to std::filesystem Move from poco::file to std::filesystem - Kernel Aug 23, 2024
@peterfpeterson peterfpeterson marked this pull request as ready for review August 23, 2024 20:45
Copy link
Collaborator

@dmitry-ganyushin dmitry-ganyushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependence from the Poco library could be completely eliminated in this PR.

@peterfpeterson peterfpeterson force-pushed the 37868_kernel_filesystem branch from 181925f to 375249d Compare August 27, 2024 20:05
@peterfpeterson peterfpeterson force-pushed the 37868_kernel_filesystem branch from 8cbf9af to 9aaf5d5 Compare August 27, 2024 20:41
Copy link
Collaborator

@dmitry-ganyushin dmitry-ganyushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

robertapplin
robertapplin previously approved these changes Aug 29, 2024
@robertapplin robertapplin enabled auto-merge August 29, 2024 13:27
Copy link
Collaborator

@dmitry-ganyushin dmitry-ganyushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@robertapplin robertapplin merged commit 4de7fa3 into mantidproject:main Aug 29, 2024
11 checks passed
@peterfpeterson peterfpeterson deleted the 37868_kernel_filesystem branch August 29, 2024 18:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants