Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate boost::filesystem to std::filesystem #37892

Merged

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Aug 28, 2024

This is a second round of many to move everything to using std::filesystem which is part of c++17. With this change, nothing links to the boost filesystem library anymore. As a bonus item, generating a fixed then string with random contents was moved into Kernel so it can be used more broadly.

Refs #37868. <!-- and fix #xxxx or close #xxxx xor resolves #xxxx. One line per issue fixed.

To test:

This is a refactor so looking at the code is enough.

This does not require release notes because it is a refactor which reduces what libraries are loaded/linked.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@peterfpeterson peterfpeterson added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Aug 28, 2024
@peterfpeterson peterfpeterson force-pushed the 37868_boost_to_std_filesystem branch from fabb3f3 to e0b6922 Compare August 28, 2024 20:21
@peterfpeterson peterfpeterson force-pushed the 37868_boost_to_std_filesystem branch from e0b6922 to 96170df Compare August 28, 2024 20:55
@peterfpeterson peterfpeterson changed the title 37868 boost to std filesystem Migrate boost::filesystem to std::filesystem Aug 28, 2024
@peterfpeterson peterfpeterson marked this pull request as ready for review August 29, 2024 00:01
@robertapplin robertapplin self-assigned this Aug 29, 2024
@robertapplin robertapplin merged commit d9ba801 into mantidproject:main Aug 29, 2024
10 checks passed
@peterfpeterson peterfpeterson deleted the 37868_boost_to_std_filesystem branch August 30, 2024 11:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants