Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fraud Proof]: osp runtime issues #752

Open
2 tasks done
Sha3nS opened this issue Mar 17, 2023 · 2 comments
Open
2 tasks done

[Fraud Proof]: osp runtime issues #752

Sha3nS opened this issue Mar 17, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@Sha3nS
Copy link
Collaborator

Sha3nS commented Mar 17, 2023

Describe the bug
verifyOneStepProof run time issues occurred in local test

  • verifyOneStepProof nil pointer
    To Reproduce
    rde make up occasionally occurred(maybe depend on different transaction types)

    Expected behavior
    call verifyOneStepProof normally

    Screenshots
    image

  • bisection execute index out of range
    To Reproduce
    rde make up occasionally occurred(maybe depend on different transaction types)

    Expected behavior
    call verifyOneStepProof normally

    Screenshots
    image

  • bisection execute index out of range
    The reason is bisection challenge assertion start inbox size is equal to parent assertion start inbox, it cause insufficient ExecutionStates generate by sequencer / validator, it's an error by challenge assertion create error

Additional context
No

@Kukoomomo
Copy link
Contributor

  • verifyOneStepProof nil pointer
    The reason for this problem is the lack of signature data in the L1toL2 transaction structure

Sha3nS added a commit that referenced this issue Mar 22, 2023
# Goals of PR

Core changes:
Fix nil point when submit proof for OSP

Related Issues:
#752
@Kukoomomo
Copy link
Contributor

Kukoomomo commented Mar 23, 2023

  • generateProofForOpcode nil point for opcode CALL 241

To Reproduce

deploy contract A and use contract B to call A then get the tx hash to generate proof for opcode 241

Expected behavior

call generateProofForOpcode normally

Screenshots

image

  • subVerifeir call exception

To Reproduce

deploy contract A and use contract B to call A then get the tx hash to generate proof for opcode 82 and then use verifier entry to call verifier2 VerifierTypeMemoryOp and then get CALL_EXCEPTION

Expected behavior

call verifyProof normally

Screenshots

image

  • subVerifeir call exception

To Reproduce

deploy contract A and use contract B to call A then get the tx hash to generate proof for opcode 84 and then use verifier entry to call verifier3 VerifierTypeStorageOp and then get CALL_EXCEPTION

Expected behavior

call verifyProof normally

Screenshots

image

@Tri-stone Tri-stone added the good first issue Good for newcomers label Jun 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants