Apply prefix to ClusterArn #342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll note that we have a workaround (renaming values before merging), so this isn't an urgent fix. |
rclark
approved these changes
Jul 8, 2020
rclark
approved these changes
Jul 9, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the specified
prefixparameter when creating the ClusterArn outputs.This is a breaking change for any consumer using the current ClusterArn output key. The previous behavior always had a
ClusterArnoutput key, and the template would fail to build with multiple distinct clusters defined. The new behavior is:WatchbotClusterArn{prefix}ClusterArnAlso, add node-modules to .gitignore.
Fixes #341