Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Animal shelter revisions #558

Merged
merged 6 commits into from
Sep 28, 2021
Merged

Animal shelter revisions #558

merged 6 commits into from
Sep 28, 2021

Conversation

samanpwbb
Copy link
Contributor

@samanpwbb samanpwbb commented Sep 24, 2021

Adds a cat icon, to represent the amenity=animal_shelter osm tag.

100% scale:
Screen Shot 2021-09-24 at 2 08 36 PM

400% scale:
Screen Shot 2021-09-24 at 2 08 45 PM

@mzdraper thanks for getting this started!

@tristen for review

@samanpwbb samanpwbb changed the title Animal shelter saman Animal shelter revisions Sep 24, 2021
@samanpwbb samanpwbb marked this pull request as draft September 24, 2021 17:41
@samanpwbb samanpwbb marked this pull request as ready for review September 24, 2021 21:09
Copy link
Member

@tristen tristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The silhouette and legibility look great. I just have some minor comments on some of the anchor points

Round x y coordinates Superflous points
Screen Shot 2021-09-27 at 3 39 40 PM Screen Shot 2021-09-27 at 3 39 49 PM

@samanpwbb
Copy link
Contributor Author

Back to you @tristen!

Round x y coordinates

The curve of the cat's back intersects the curve of the cat's neck at an unround coordinate. I think this is fine, otherwise we'd lose the head's vertical symmetry.

@samanpwbb
Copy link
Contributor Author

Lol no, wait, I don't have permission to commit any more. One sec.

@samanpwbb samanpwbb mentioned this pull request Sep 28, 2021
@tristen
Copy link
Member

tristen commented Sep 28, 2021

👉 #559

@tristen tristen closed this Sep 28, 2021
@tristen tristen deleted the animal-shelter-saman branch September 28, 2021 14:15
@tristen tristen restored the animal-shelter-saman branch September 28, 2021 14:18
@tristen tristen reopened this Sep 28, 2021
Copy link
Member

@tristen tristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@tristen tristen merged commit 3fcab07 into main Sep 28, 2021
@tristen tristen deleted the animal-shelter-saman branch September 28, 2021 14:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants