[v4] create collapsed option #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katydecorah
changed the title
API.md
Outdated
| @@ -28,6 +28,7 @@ A geocoder component using Mapbox Geocoding API | |||
| properties. Search results closer to this point will be given | |||
| higher priority. | |||
| - `options.trackProximity` **[Boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)** If true, the geocoder proximity will automatically update based on the map view. (optional, default `true`) | |||
| - `options.collapsed` **[Boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)** If true, the geocoder control will collapse unless until hovered or in focus. (optional, default `false`) | |||
There was a problem hiding this comment.
"unless until", maybe just "until"?
added 2 commits
March 20, 2019 13:59
* version4: (25 commits) fix focus trap (#220) add `npm run docs` step to template (#221) Fix typo in documentation additional properties existance check Ensure properties exist prior to checking id update changelog remove use of hardcoded feature IDs update outdated packages with npm update update changelog Bump insecure dev dependencies tests for options.flyTo Update changelog update jsdoc and api docs pass flyTo options to map upon selection extend eslint, add precommit hook (#210) replace sha.js with nanoid reduce bundle size to 42kb (13kb gzipped) [docs] update deploy process (#198) prepare to publish v3.1.6 update package-lock bump package version to v3.1.5 ...
katydecorah
changed the title
scottsfarley93
approved these changes
Mar 21, 2019
test/test.geocoder.js
Outdated
| @@ -513,5 +513,54 @@ test('geocoder', function(tt) { | |||
| t.end(); | |||
| }); | |||
|
|
|||
| tt.test('options.collapsed=true', function(t) { | |||
There was a problem hiding this comment.
nitpick: these tests look good, but should we move them to test.ui.js since they generally handle the testing of UI elements?
added 3 commits
March 21, 2019 15:05
* version4: Update documentation with documentation@9.3.0 suggestions@v1.4.0 Update jsdoc strings add get/set functions expose render and getItemValue functions as constructor options
|
the Also, if it's in a block of text, it may wrap to the next line when expanded, causing it to be unhovered, causing it to collapse, causing it to be hovered, causing it to expand, ... Not sure how to take a video on my computer, but here's some screenshots. I can't stay hovered over both versions. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterheading before mergingThis PR adds a
collapsedoption that will collapse the geocoder controller into a button. When hovered or focused, the controller will open up. It will collapse once the user focuses or hovers away from the controller, but only if they have cleared the search.refs #89 (comment)