Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

map.getStyle() modification issue #4488

Merged
merged 8 commits into from
Aug 14, 2024
Merged

map.getStyle() modification issue #4488

merged 8 commits into from
Aug 14, 2024

Commits on Aug 1, 2024

  1. unit test to demonstrate issue

    @gavinr-maps
    gavinr-maps committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    fe7957b View commit details
    Browse the repository at this point in the history

  2. return a cloned copy 

    to ensure the value cannot be written by the user
    @gavinr-maps
    gavinr-maps committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b6f5c73 View commit details
    Browse the repository at this point in the history

  3. changelog for map.getStyle() bug fix

    @gavinr-maps
    gavinr-maps committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    17758be View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into 4481-getstyle-modif… 

    …y-style-issue

# Conflicts:
#	CHANGELOG.md
    @gavinr-maps
    gavinr-maps committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b984df5 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. use async/await in test 

    per PR feedback
    @gavinr-maps
    gavinr-maps committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    988cab6 View commit details
    Browse the repository at this point in the history

  2. flag for returning the clone

    @gavinr-maps
    gavinr-maps committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4b917cf View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 4481-getstyle-modify-style-issue

    @HarelM
    HarelM committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4213172 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md

    @HarelM
    HarelM committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4bfae9f View commit details
    Browse the repository at this point in the history