Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix horizon-fog-belnd where sky is not set. #4607

Merged
merged 5 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

- Heatmap Fix for 3D terrain ([#4571](https://github.com/maplibre/maplibre-gl-js/pull/4571))
- Fix Map#off to not remove listener with layer(s) registered with Map#once ([#4592](https://github.com/maplibre/maplibre-gl-js/pull/4592))
- Fix the color near the horizon when terrain is enabled without any sky ([#4607](https://github.com/maplibre/maplibre-gl-js/pull/4607))
- _...Add new stuff here..._

## 4.6.0
Expand Down
2 changes: 2 additions & 0 deletions src/style/sky.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ export class Sky extends Evented {
'sky-color': 'transparent',
'horizon-color': 'transparent',
'fog-color': 'transparent',
'fog-ground-blend': 1,
'atmosphere-blend': 0,
};
}

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
46 changes: 46 additions & 0 deletions test/integration/render/tests/terrain/fog-no-sky-blend/style.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
{
"version": 8,
"sprite": "local://sprites/sprite",
"glyphs": "local://glyphs/{fontstack}/{range}.pbf",
"timeout": 60000,
"metadata": {
"test": {
"height": 512,
"width": 512,
"maxPitch": 85,
"operations": [
["wait"]
]
}
},
"center": [
35.38,
31.55
],
"zoom": 15,
"pitch": 85,
"sources": {
"terrain": {
"type": "raster-dem",
"tiles": [
"local://tiles/zero-elevation-terrain-tile.png"
],
"minzoom": 7,
"maxzoom": 12,
"tileSize": 256
}
},
"layers": [
{
"id": "background",
"type": "background",
"paint": {
"background-color": "red"
}
}
],
"terrain": {
"source": "terrain",
"exaggeration": 1
}
}