Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vertex decoding is incorrect in non-vectorized path #134

Closed
springmeyer opened this issue Jun 12, 2024 · 1 comment
Closed

Vertex decoding is incorrect in non-vectorized path #134

springmeyer opened this issue Jun 12, 2024 · 1 comment

Comments

@springmeyer
Copy link
Collaborator

Seeing geometries like:

POINT (-13 -9)

That should be:

POINT (25 17)

This impacts all geometry types.

@springmeyer
Copy link
Collaborator Author

Fixed by #129

springmeyer added a commit that referenced this issue Jun 13, 2024
This PR includes various improvements and fixes to the java
implementation.

It includes several fix issues in the non-vectorized path, bringing it
back up to speed with the vectorized path:
 - #134 
 - #131 
 - #130 

And in includes two general encoding features that were missing:

 - #132 
 - #127

Additional changes, that don't have corresponding tickets:

- Fixed the Delta encoding in the non-vectorized path to support RLE
without multiple passes
- Improves the `encode` and `decode` cli tools to actually decode
vectorized geometries when `-decode` arg is passed
- Make the spotless check run faster (avoids running builds and tests
and just does the formatting check)
- Fixes a small bug in the vectorized path where the signed boolean was
incorrect
- Makes the benchmark timer in the encode and decode tools quiet by
default and now behind an option
- Adds additional error detail when unsupported encodings are
encountered at runtime
 - Comments some unused code
- Renames some code to match naming better between the vectorized and
non-vectorized path
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant