Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Readme.md container port changed to 80 #881

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

glebpinigin
Copy link
Contributor

@glebpinigin glebpinigin commented Feb 8, 2024

Activating maputnik with docker run requires to bind port 80 from container and not 8888, because nginx is running with default config and listening port 80

For npm run port 8888 is explicitly set up in config.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc5ecfa) 57.17% compared to head (38f1183) 57.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #881   +/-   ##
=======================================
  Coverage   57.17%   57.17%           
=======================================
  Files         104      104           
  Lines        2940     2940           
  Branches      670      670           
=======================================
  Hits         1681     1681           
  Misses       1259     1259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit b9e3289 into maplibre:main Feb 8, 2024
7 checks passed
@HarelM
Copy link
Collaborator

HarelM commented Feb 8, 2024

Thanks!

@glebpinigin glebpinigin deleted the port-readme branch April 18, 2024 09:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants