Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Temp fix using patch-package for maplibre-inspect issue #885

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Mar 9, 2024

This is a temporary fix for:

The fix is using patch-package to fix the part of the code that is causing the issue, I believe.
Initial tests shows that this is fixing the issue, I hope it is not introducing other issues.
A proper fix and also using the maplibre package will be done once a repo is migrated as can be expected after the following PR is resolved:

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.19%. Comparing base (3727f5d) to head (7ef4821).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   57.19%   57.19%           
=======================================
  Files         104      104           
  Lines        2939     2939           
  Branches      670      670           
=======================================
  Hits         1681     1681           
  Misses       1258     1258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but comment needs minor improvement

@HarelM HarelM merged commit 5f54dd0 into main Mar 9, 2024
8 checks passed
@HarelM HarelM deleted the 871-temp-fix branch March 9, 2024 21:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants