Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace mapbox-gl-inspect with maplibre-gl-inspect #888

Merged
merged 7 commits into from
Mar 13, 2024
Merged

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Mar 13, 2024

This hopefully fixes #871

I still need to update maplibre-gl-inspect to allow this to be fixed.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 57.28%. Comparing base (5f54dd0) to head (8e587b7).

❗ Current head 8e587b7 differs from pull request most recent head 3a809cb. Consider uploading reports for the commit 3a809cb to get more accurate results

Files Patch % Lines
...c/components/MapMaplibreGlFeaturePropertyPopup.tsx 0.00% 8 Missing ⚠️
src/components/MapMaplibreGlLayerPopup.tsx 42.85% 4 Missing ⚠️
src/components/MapMaplibreGl.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
+ Coverage   57.23%   57.28%   +0.05%     
==========================================
  Files         104      104              
  Lines        2939     2936       -3     
  Branches      670      670              
==========================================
  Hits         1682     1682              
+ Misses       1257     1254       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM marked this pull request as ready for review March 13, 2024 20:31
@HarelM HarelM requested a review from nyurik March 13, 2024 20:38
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HarelM HarelM merged commit 3c043fd into main Mar 13, 2024
8 checks passed
@HarelM HarelM deleted the maplibre-gl-inspect branch March 13, 2024 20:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-initialize map view after changing style
3 participants