#211 Remove methods should not be considered fluent setters. #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you mentioned in #211, this depends on mapstruct/mapstruct#3072. To ensure consistency across all versions, the check should only be applied when a MapStruct version is detected in which the issue has been resolved. |
|
Thanks for the feedback. As soon as (and if) mapstruct/mapstruct#3072 is approved and merged, I will update the PR with a suggestion on how to do it. I guess that to extend MapStructVersion and MapstructUtil::resolveMapStructProjectVersion is the way to go. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first take on it.
With this change fluent remover's will be ignored when verifying the mapper. A remover (removePassenger) is added to FluentCarDTO as part of the tests.
Tested it with IntelliJ as well and seems to be working as intended, but I would be more than happy for feedback and suggestions.