Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fancy tree with wide extension doesn't handle correctly left padding. #616

Closed
sbespaly opened this issue Jul 11, 2016 · 9 comments
Closed

Comments

@sbespaly
Copy link
Contributor

Expected and actual behavior

When I set left padding for the tree when using wide extension, node title partially covered with node icon and node expander icons. This happens because wide extension doesn't handle custom margins.
Is it possible to handle left padding in wide extension or add configuration option where i can set it manually.

@mar10
Copy link
Owner

mar10 commented Jul 12, 2016

Would it be possible to add a margin instead or wrap the tree inside another div?

@mar10 mar10 closed this as completed Jul 12, 2016
@sbespaly
Copy link
Contributor Author

No. that would work only for tree without wide extension. If I add left margin to the tree, that would move wide selection from the right. And when I apply margin to first LI element in tree expanders icons and check boxes are positioned correctly except node title element. It holds the same position. Because wide extension doesn't handle this situation.
tree_margin

@mar10 mar10 reopened this Jul 21, 2016
@mar10 mar10 changed the title Fancy tree with wide extension doesn't hanle correctly left padding. Fancy tree with wide extension doesn't handle correctly left padding. Aug 12, 2016
@sbespaly
Copy link
Contributor Author

Hi.
Do you have any plans for this issue ?
If not and if it's not complicate to fix. I can fix it. What do you think about that ?

@mar10
Copy link
Owner

mar10 commented Dec 21, 2016

That would certainly help, since I am a bit busy right now.
Before fixing it, can you post a jsFiddle, Plunkr, or another live example that we can look into, and discuss possible aprocaches?

@sbespaly
Copy link
Contributor Author

sbespaly commented Feb 9, 2017

You can see the issue even in your wide example
http://wwwendt.de/tech/fancytree/demo/index.html#sample-ext-wide.html
Just select Win8 xxl skin and try to expand\collapse any node. When animation in progress you can see that node label is jumping to the left.

P.S. I prepared fix for this issue, not perfect, but works for me. Fix it by adding additional parameter into wide extension options, which will be used for animation styles generation.

sbespaly added a commit to sbespaly/fancytree that referenced this issue Feb 9, 2017
mar10 pushed a commit that referenced this issue Apr 1, 2017
#685)

* Fix for issue #616. Fancy tree with wide extension doesn't handle correctly left padding.

* Fix jshint & whitespace
@mar10 mar10 closed this as completed Apr 1, 2017
mar10 added a commit that referenced this issue Apr 2, 2017
mar10 added a commit that referenced this issue Apr 2, 2017
@Toykan
Copy link

Toykan commented Nov 15, 2018

Fancy tree expander isn't working. What would be the reason? Gets the following error.
Uncaught TypeError: Cannot read property 'replace' of undefined

Double-click on the folder , but it doesn't open when click the arrow on the left

@mar10
Copy link
Owner

mar10 commented Nov 15, 2018

@Toykan how is this related to this issue and the wide extension ?
Please provide more information on how to reproduce the problem - preferably in a new issue

@Toykan
Copy link

Toykan commented Nov 16, 2018 via email

@mar10
Copy link
Owner

mar10 commented Nov 16, 2018

Please read may last comment and open a new issue with a detailed explanation. There is no 'pic2' btw.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants