Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

2.20 broke DND for me #705

Closed
chino23 opened this issue Mar 20, 2017 · 2 comments · Fixed by #706
Closed

2.20 broke DND for me #705

chino23 opened this issue Mar 20, 2017 · 2 comments · Fixed by #706

Comments

@chino23
Copy link
Contributor

chino23 commented Mar 20, 2017

c250f70 broke the DND for me.

It introduced the search for

find(">span.fancytree-title")

on the node.

However, my node is customized a bit and the fancytree-title class isn't a direct child, but one level down. So it throws errors when dragging.

I made it work by changing these lines
https://github.com/mar10/fancytree/blob/master/src/jquery.fancytree.dnd.js#L309
https://github.com/mar10/fancytree/blob/master/src/jquery.fancytree.dnd5.js#L165

to:

$targetTitle = $target.find("span.fancytree-title");

effectively removing the >

Could this be considered to be implemented?

@mar10
Copy link
Owner

mar10 commented Mar 20, 2017

Sure. Would you like to submit a PR?

@chino23
Copy link
Contributor Author

chino23 commented Mar 21, 2017

Submitted #706

Thank you, Martin.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants