fix read stderr during command execution #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently stderr is only read after stdout ended sending (= after the called bash command ended). With this change, stderr and stdout is read simultanously via two separate threads to make it possible that stderr is read before the command ended.
How to test this
Create file
test-stderr.sh
:Create file
test-stdout.sh
:When you set up a pipeline with a
RunBash
command callingtest-stdout.sh
, you will see the output during execution. When you do the same with callingtest-stderr.sh
, you will get the log output in mara only after the shell script ended.With this pull request, this behavior will change so that stdout/stderr reading happens during command execution, so,
test-stderr.sh
will show the log output right away. You don't have to wait until the shell command ended before you can seestderr
in the mara log.