Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support parallel tests #33

Closed
marcos8896 opened this issue Sep 7, 2018 · 0 comments
Closed

Support parallel tests #33

marcos8896 opened this issue Sep 7, 2018 · 0 comments
Assignees
@brandonvilla21 @marcos8896
Labels
enhancement New feature or request feature

Comments

@marcos8896
Copy link
Owner

In order to support parallel integration test without collisions between them, it will be required to add multiple databases and ports for testing porpuses and maybe a fix maxWorkers for Jest.

Currently, all the test are running synchronously with maxWorkers=1, because of the same problem with collisions between database calls and ports.

A good fixed value for maxWorkers would be "4", but it will require some extra work to properly do it.

A good place to start would be this issue, in which it is mentioned that for this kind of cases it will be possible to do something like this:

const port = 3000 + process.env.JEST_WORKER_ID
@marcos8896 marcos8896 added enhancement New feature or request feature labels Sep 7, 2018
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#31) - Set maxWorkers to 1 provisionally for the Jest test
0ac8f90 
It is required to set multiple ports and databases in order to
support the parallel worker feature.

Related issue:
#33
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) - Add portfinder package to the project
286fa67 
Allow to find available ports.
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) - Add environment test utils to handle ports and baseURL
f6c87c2
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) Remove port from config.test.js and manage it inside tests
dabac00
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) - Implemented 'createTestingDatabase' function for testing
d160305
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) - Refactored body-area.service file to support concurrent db test
5ee0628
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) - Fix createApiUnauth in auth-util file
b6f9712 
It was returning the wrong value
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) - Remove portfinder package
2e734cf 
The package did not solve the problem with ports collision.
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) - Add getApiTestPort to generate a port for the testing API
c67119d
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) Adapt the body-area tests to the new parallel approach
4e926c7
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) Adapt the diet tests to the new parallel approach
46e6269
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) - Add restriction to the maxWorkers generated by parallel tests
a572cd0
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) - database-utils only can be required in a test environment
21a20f8
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) - Add integrationTestSetup to abstract away the setup complexity
e7958fa 
Abstract away the setup complexity needed to configure the testing
environment.
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) - Add integrationTestSetup usage to the diet.service tests
3ab484e
marcos8896 added a commit that referenced this issue Sep 7, 2018
@marcos8896
(#33) - Add integrationTestSetup usage to the body-area.service tests
240d108 
Allow to remove the complexity to setup the integration test
environment
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@brandonvilla21 brandonvilla21

@marcos8896 marcos8896

Labels
enhancement New feature or request feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonvilla21 @marcos8896