fix: enforce max character length of 100 for name and value in autoco…

…mplete
mariusbegby · Jul 28, 2023 · 724f407 · 724f407
1 parent 7428323
commit 724f407
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/src/commands/player/lyrics.js b/src/commands/player/lyrics.js
@@ -41,13 +41,13 @@ module.exports = {
                     `${track.title} [Artist: ${track.author}]`.length > 100
                         ? `${track.title}`.slice(0, 100)
                         : `${track.title} [Author: ${track.author}]`,
-                value: track.title
+                value: track.title.slice(0, 100)
             }));
         } else {
             response = [
                 {
-                    name: `${lyricsResult.title} [Artist: ${lyricsResult.artist.name}]`,
-                    value: lyricsResult.title
+                    name: `${lyricsResult.title} [Artist: ${lyricsResult.artist.name}]`.slice(0, 100),
+                    value: lyricsResult.title.slice(0, 100)
                 }
             ];
         }

diff --git a/src/commands/player/play.js b/src/commands/player/play.js
@@ -34,13 +34,18 @@ module.exports = {
 
         logger.debug(`[Shard ${interaction.guild.shardId}] Autocomplete search responded for query: ${query}`);
 
-        response = searchResults.tracks.slice(0, 5).map((track) => ({
-            name:
-                `${track.title} [Author: ${track.author}]`.length > 100
-                    ? `${track.title}`.slice(0, 100)
-                    : `${track.title} [Author: ${track.author}]`,
-            value: track.url
-        }));
+        response = searchResults.tracks.slice(0, 5).map((track) => {
+            if (track.url.length > 100) {
+                track.url = track.title.slice(0, 100);
+            }
+            return {
+                name:
+                    `${track.title} [Author: ${track.author}]`.length > 100
+                        ? `${track.title}`.slice(0, 100)
+                        : `${track.title} [Author: ${track.author}]`,
+                value: track.url
+            };
+        });
 
         if (!response || response.length === 0) {
             return interaction.respond([]);