-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Docs navigation #1156
Docs navigation #1156
Conversation
We should probably also make a way to be able to link to different parts of the site. Because this is a SPA there is no way to view AUTHORS.md without clicking on a link in https://marked.js.org/ |
@UziTech: I was wondering if a SPA would be the desired approach or not. Namely because of the double-anchor problem. /# (makes it a SPA) /#something#inline (becomes a different problem to solve). One way to do it would be to use multiple index.html file within directories. Or, use something like VueJS or Angular. |
Would also be nice if the README still linked to different documents. Like having two links in the usage section - one to the advanced and another to the pro. |
Ya I through together a I'm thinking the index files in directories would be a better solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an improvement
I was thinking of using urls like This would give us a way to render additional non-docs pages that are not part of the docs SPA such as |
That alternative make my UX brain hiccup a bit...to computer, not enough human, if that makes sense. Same issues with A router that doesn't break that back and forward buttons, while also allowing for inline anchors. Still thinking the cheapest and easiest would be multiple index.html files:
Just clean and simple human readable urls. Only drawback is that there would be some duplication of code...but I don't think it's that big of a deal for such a small static site. ?? |
Just realized the demo thing is what #64 is about. :) |
Or we could avoid re-inventing the wheel and go with this: https://docsify.js.org |
Interesting. Could we use Jekyll (native GitHub Pages). Given our current focus - we could use the marked site to showcase some of our personal projects...touching on the professional growth itch. I've been working on a design system based on the USWDS for 8fold and the practitioner sites: https://www.npmjs.com/package/8fold-web-assets Definitely thinking starting a separate repo would be good as well. I don't mind reimagining the wheel so long as it helps us grow professionally in an environment that's not mission critical to us eating. :) |
Docs navigation
Marked version: latest
Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a
Description
This PR adds a ribbon that links to the github repo and adds a link to marked icon back to the README.md
Contributor
Committer
In most cases, this should be a different person than the contributor.