Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Defibrillator badge to tomtheisen #1241

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Defibrillator badge to tomtheisen #1241

merged 2 commits into from
Apr 25, 2018

Conversation

joshbruce
Copy link
Member

@joshbruce joshbruce commented Apr 25, 2018

@mention the contributor: @tomtheisen

Recommendation to:

  • Change user group
  • Add a badge
  • Remove a badge

See #1239

As the one mentioned, I would like to:

  • accept the recommendation; or,
  • graciously decline; or,
  • dispute the recommendation

within 30 days, if you have not indicated which option you are taking one of the following will happen:

  1. If adding a badge, we will assume you are graciously declining.
  2. If removing a badge, we will assume you do not want to dispute the recommendation; therefore, the badge will be removed.

Note: All committers must approve via review before merging, the disapproving committer can simply close the PR.

@tomtheisen
Copy link

How do I indicate my acceptance? Just by saying so here? Here's me, saying so.

@UziTech
Copy link
Member

UziTech commented Apr 25, 2018

@tomtheisen do you want your real name listed? if so what is it?

@tomtheisen
Copy link

List me as "Tom Theisen"

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the name

@joshbruce
Copy link
Member Author

@tomtheisen: I know this is different than other places. Thank you for the feedback, we're always iterating to improve. To accept, you just hit the checkmark in the second set of checkboxes.

@joshbruce
Copy link
Member Author

ps. Now we just wait for everyone to approve.

@styfle styfle merged commit 7bf0f73 into markedjs:master Apr 25, 2018
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants