Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enable CommonMark spec 468 #1305

Merged
merged 1 commit into from
Jul 6, 2018
Merged

enable CommonMark spec 468 #1305

merged 1 commit into from
Jul 6, 2018

Conversation

Trott
Copy link
Contributor

@Trott Trott commented Jul 3, 2018

Marked version: 0.4.0

Markdown flavor: CommonMark

Description

A minor adjustment to the href-matching regexp permits CommonMark spec
468 to pass. All other passing specs are unaffected.

The regexp was incorrectly excluding parentheses as valid characters in
a URL.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

A minor adjustment to the href-matching regexp permits CommonMark spec
468 to pass. All other passing specs are unaffected.

The regexp was incorrectly excluding parentheses as valid characters in
a URL.
@joshbruce joshbruce requested a review from davisjam July 5, 2018 16:54
@styfle
Copy link
Member

styfle commented Jul 6, 2018

Thanks!

@styfle styfle merged commit 51cd03f into markedjs:master Jul 6, 2018
@styfle
Copy link
Member

styfle commented Jul 6, 2018

Oops, I just saw the request for @davisjam to review 😮

@davisjam This isn't vulnerable to ReDOS, correct? 👀

@davisjam
Copy link
Contributor

davisjam commented Jul 9, 2018

@styfle Just got a chance to look at this.

I will cryptically remark that its vulnerability status is unchanged.

@styfle styfle added this to the 0.5.0 - Commonmark Compliance milestone Aug 15, 2018
@Feder1co5oave Feder1co5oave mentioned this pull request Jan 13, 2019
This was referenced Apr 6, 2020
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants