Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix breaks option description #1381

Merged
merged 1 commit into from
Nov 28, 2018
Merged

fix breaks option description #1381

merged 1 commit into from
Nov 28, 2018

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Nov 27, 2018 •
edited by styfle
Loading

Fix the description for the "breaks" option

Marked version: master

Markdown flavor: Docs

Description

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

styfle
styfle approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny, that's what I thought it did but when I looked at the docs it seemed pretty specific.

The soft/hard break terminology is confusing 😕

Glad we got some consensus on this and it was simply the docs being wrong 😄

joshbruce
joshbruce approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@joshbruce joshbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Steve. Thanks!

@styfle styfle merged commit bf973d2 into markedjs:master Nov 28, 2018
@UziTech UziTech deleted the breaks-option branch February 19, 2019 20:22
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
This was referenced Oct 26, 2019
Open
Open
Open
Closed
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 4, 2019
Open
This was referenced Nov 18, 2019
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@sasinetindia sasinetindia mentioned this pull request Oct 27, 2024
Open
@moamed-syed moamed-syed mentioned this pull request Oct 27, 2024
Open
@ManPrivate ManPrivate mentioned this pull request Oct 27, 2024
Open
@tdsnyk tdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankari sri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931 mohankumar931 mentioned this pull request Oct 28, 2024
Open
@sound25 sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtm Latha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDAN GOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024 Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiya ThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Upender5119 Upender5119 mentioned this pull request Oct 30, 2024
Open
@Suriya0802 Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12 Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007 Magali0007 mentioned this pull request Oct 31, 2024
Open
@sureshrtech1 sureshrtech1 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349 Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@robertnorrie robertnorrie mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnan sinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@krithika-manohar krithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55 SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-ra swathi-ra mentioned this pull request Nov 2, 2024
Open
@austinskou austinskou mentioned this pull request Nov 3, 2024
Open
@BD-HUGO BD-HUGO mentioned this pull request Nov 3, 2024
Open
@danielsb74 danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26 selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldev merkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-git joedean-git mentioned this pull request Nov 9, 2024
Open
@MimiDas-Snyk MimiDas-Snyk mentioned this pull request Nov 10, 2024
Open
@BenDrKo BenDrKo mentioned this pull request Nov 11, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@styfle styfle styfle approved these changes

@Feder1co5oave Feder1co5oave Feder1co5oave approved these changes

@joshbruce joshbruce joshbruce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UziTech @styfle @Feder1co5oave @joshbruce