Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix blockquote paragraph continuation #1394

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Conversation

mccraveiro
Copy link
Contributor

@mccraveiro mccraveiro commented Dec 19, 2018

Marked version: master branch

Markdown flavor: CommonMark

Description

Input

> foo
    - bar

Expectation

<blockquote>
<p>foo
- bar</p>
</blockquote>

Result

<blockquote>
<p>foo</p>
<pre><code>- bar</code></pre></blockquote>

What was attempted

Fix blockquote paragraph continuation by limiting whitespaces before list item

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech
Copy link
Member

UziTech commented Dec 19, 2018

what is the input you are testing for the expected and actual output?

@mccraveiro
Copy link
Contributor Author

@UziTech I've updated the description with the actual input. Sorry :)

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep up the good work

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@styfle styfle merged commit 2a9f782 into markedjs:master Dec 20, 2018
@mccraveiro mccraveiro deleted the blockquote branch December 20, 2018 16:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants