-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Pretty print ENOENT errors on cli #1396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if this is the correct solution. It would be easier to debug with the stack trace. If we want to fix #205 we should catch that error and show a relevant message. |
could be something like marked: output to nonexistent_dir/test.html: No such directory The way this PR is right now the output would be Error: ENOENT, open 'nonexistent_dir/test.html' which is not much more helpful. |
9c7a2dd
to
8f532f0
Compare
8f532f0
to
327c9d8
Compare
@UziTech done :) |
UziTech
approved these changes
Dec 20, 2018
styfle
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Nov 18, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: master branch
Markdown flavor: n/a
Description
Hide the JS stack trace on CLI errors
Contributor
Committer
In most cases, this should be a different person than the contributor.