Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add --test man documentation and changes argv parameters test/index.js #1442

Merged
merged 12 commits into from
Mar 12, 2019

Conversation

x13machine
Copy link
Contributor

@x13machine x13machine commented Mar 10, 2019

Marked version:

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

  • Added --test man documentation in response to Add --test option in man page #1423. I don't know If I'm using the correct groff format. I ran "man -P cat ./marked.1 > marked.1.txt" to write the "marked.1.txt" file. I don't know if that's what I'm suppose to do.
  • Changed the parseArg code in test/index.js because it was using process.argv and not argv.
    var opt = parseArg();

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@x13machine
Copy link
Contributor Author

I meant --minified and not --run. The loose parameter was a mistake.

@UziTech
Copy link
Member

UziTech commented Mar 11, 2019

To make the tests pass you will have to change /test/specs/original/specs-spec.js line 6

-  if (!specTests({stop: true})) {
+  if (!specTests(['', '', '--stop'])) {

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants