Update tests to node 4 syntax #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Mar 13, 2019
styfle
reviewed
Mar 13, 2019
test/helpers/helpers.js
Outdated
| } | ||
| result.message = 'Expected:\n' + expectedHtml + '\n\nActual:\n' + actualHtml; | ||
| const diff = htmlDiffer.firstDiff(actual, expected); | ||
| result.message = 'Expected: ' + diff.expected + '\n Actual: ' + diff.actual; |
There was a problem hiding this comment.
Suggested change
| result.message = 'Expected: ' + diff.expected + '\n Actual: ' + diff.actual; | |
| result.message = `Expected: ${expected}\nActual: ${actual}`; |
styfle
reviewed
Mar 13, 2019
test/index.js
Outdated
| @@ -289,13 +245,13 @@ function runBench(options) { | |||
| } | |||
| bench('marked (pedantic)', files, marked); | |||
|
|
|||
| // showdown | |||
| // commonmark | |||
There was a problem hiding this comment.
Let's remove these comments since they are redundant
davisjam
reviewed
Mar 13, 2019
davisjam
approved these changes
Mar 13, 2019
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: master
Description
Update all tests to use html-differ and use syntax for node 4
Contributor
Committer
In most cases, this should be a different person than the contributor.