-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(fix): Fix some problems with demo quickref #1682
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/cl4116sce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! There are a few things to fix.
and find that it's just wrapped in a `<p>` tag and *won't* be shown | ||
as preformatted text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and find that it's just wrapped in a `<p>` tag and *won't* be shown | |
as preformatted text. | |
and find that it's just wrapped in a `<p>` tag and *won't* be shown | |
as preformatted text. |
You can keep adding more and more paragraphs to a single | ||
list item by adding the traditional blank line and then keep | ||
on indenting the paragraphs with four spaces. You really need | ||
to only indent the first line, but that looks ugly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can keep adding more and more paragraphs to a single | |
list item by adding the traditional blank line and then keep | |
on indenting the paragraphs with four spaces. You really need | |
to only indent the first line, but that looks ugly. | |
You can keep adding more and more paragraphs to a single | |
list item by adding the traditional blank line and then keep | |
on indenting the paragraphs with four spaces. You really need | |
to only indent the first line, but that looks ugly. |
@@ -130,7 +133,7 @@ to only indent the first line, but that looks ugly. | |||
|
|||
- Lists support preformatted text | |||
|
|||
You just need to indent eight spaces. | |||
You just need to indent eight spaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You just need to indent eight spaces. | |
You just need to indent six spaces. |
@hughsw are you interested in continuing with this PR? |
Marked version:
npm: 1.1.0
Markdown flavor: n/a
Description
demo/quickref.md
Expectation
Documentation will have correct English, all examples will work
Result
There are a couple of typos, and some of the examples don't work
What was attempted
I'm learning marked -- it's my first time looking at the docs
Contributor
Committer
In most cases, this should be a different person than the contributor.