Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

BREAKING CHANGE: clean up rules so they can be typed #3087

Merged
merged 10 commits into from
Nov 29, 2023
Merged

BREAKING CHANGE: clean up rules so they can be typed #3087

merged 10 commits into from
Nov 29, 2023

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Nov 13, 2023 •
edited
Loading

Marked version: 10.0.0

Clean up rules so they can be easily typed.

This will be a breaking change because the rules object has changed.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel Vercel
Copy link

vercel bot commented Nov 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 4:44am

@UziTech UziTech changed the title fix: clean up rules so they can be typed BREAKING CHANGE: clean up rules so they can be typed Nov 14, 2023
@UziTech UziTech marked this pull request as ready for review November 14, 2023 05:46
@UziTech UziTech merged commit 175fc0c into markedjs:master Nov 29, 2023
github-actions bot pushed a commit that referenced this pull request Nov 29, 2023
@semantic-release-bot
chore(release): 11.0.0 [skip ci]
f45cfc3 
# [11.0.0](v10.0.0...v11.0.0) (2023-11-29)

### Bug Fixes

* clean up rules so they can be typed ([#3087](#3087)) ([175fc0c](175fc0c))
* fix marked types ([#3103](#3103)) ([edae309](edae309))

### BREAKING CHANGES

* Lexer.rules object has been changed so it can be properly types. Some intermediate rules have been removed.
@UziTech UziTech deleted the rules-types branch November 29, 2023 07:58
@Pezmc Pezmc mentioned this pull request Jan 30, 2024
Merged
@mnathsnyk mnathsnyk mentioned this pull request Mar 15, 2024
Open
This was referenced Jun 19, 2024
Open
Closed
@leonardoadame leonardoadame mentioned this pull request Jul 3, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jul 4, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Jul 15, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jul 16, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@styfle styfle Awaiting requested review from styfle

@calculuschild calculuschild Awaiting requested review from calculuschild

@joshbruce joshbruce Awaiting requested review from joshbruce

@davisjam davisjam Awaiting requested review from davisjam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@UziTech